Repository navigation
Add ReSolve HyKKT integration - #12
Closed
tamar-dewilde wants to merge 18 commits into
Closed
tamar-dewilde wants to merge 18 commits into
tamar-dewilde wants to merge 18 commits into
Conversation
Collaborator
Author
|
Validated the ReSolve HyKKT integration against HiOp CPU
CUDA
HIP
The targeted HyKKT tests completed successfully on CPU, hybrid CUDA, CUDA/RAJA, and HIP/RAJA paths. Full validation logs: |
Collaborator
|
Closing in favor of #14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for using ReSolve's HyKKT solver from HiOp.
HyKKT operates directly on the sparse KKT matrix blocks instead of using the existing ReSolve sparse linear solver interface. The integration builds the ReSolve matrix and vector blocks, updates their numerical values between HiOp iterations, and transfers the right-hand side and solution between HiOp and ReSolve.
The integration supports CPU, hybrid, and GPU execution using HiOp's existing memory and compute modes.
@pelesh
Proposed changes
hiopKKTLinSysCompressedSparseXDYcYdHyKKTas the HiOp interface to ReSolve HyKKT.mem_spaceandcompute_modesettings.linear_solver_sparse=hykkt,hykkt_gamma, andhykkt_residual_toloptions.xdycydKKT formulation for HyKKT, selecting it whenKKTLinsys=autoand falling back tolinear_solver_sparse=autowhen an incompatible KKT formulation is explicitly requested.-hykktsupport to the sparse and RAJA example drivers.solve().build_kkt_matrix()failures throughhiopKKTLinSysCurvCheck::factorize()andfactorize_inertia_free()so HyKKT setup failures are returned to the optimization algorithm.Checklist
NlpSparse2_HyKKTNlpSparse2_HyKKT(hybrid) andNlpSparseRaja2_HyKKT_CUDANlpSparse2_HyKKTandNlpSparseRaja2_HyKKT_HIP-Wall -Wpedantic -Wconversion -Wextra.Further comments
This draft is based on
tamar/resolve-integration-cleanupand depends on those ReSolve integration changes. It will remain a draft while the prerequisite changes are under review. Once they are merged, the base can be updated or the branch rebased before marking this ready for review.There are several current limitations to the HyKKT integration:
HyKKTSolver::solve(). As a result, factorization failure cannot currently participate in HiOp's regularization retry path in the same way as the existing direct sparse solvers.ir_outer_maxit=0because HyKKT performs a complete factorization and solve for each call. This is currently set by the example drivers rather than enforced for all uses oflinear_solver_sparse=hykkt.This also changes the shared
hiopKKTLinSysCurvCheckfactorization path so that failures returned bybuild_kkt_matrix()are propagated instead of being discarded. Among the existing implementations, this can affecthiopKKTLinSysCondensedSparseandhiopKKTLinSysSparseNormalEqn, which have matrix-build failure paths, in addition to HyKKT.