Repository navigation
Add state_file solver option for PhasorDynamics - #652
Merged
Merged
Conversation
Collaborator
Author
|
@nkoukpaizan @pelesh This is the highest value next migration step |
nkoukpaizan
approved these changes
Nov 11, 2026
Collaborator
There was a problem hiding this comment.
Looks good!
I'll merge once rebased and CHANGELOG conflict is resolved and CI passes. Expect CI to fail for some time because of a GitHub actions issue.
| for (auto& bus : sm.bus) | ||
| { | ||
| const auto number = std::to_string(bus.bus_id); | ||
| if (buses.contains(number)) |
Collaborator
There was a problem hiding this comment.
[Minor, thoughts for future PRs] Is there an acceptable situation where this condition will not be met? Perhaps we need some validation between the state and case files. A mismatch would be silent here.
Collaborator
Author
There was a problem hiding this comment.
I agree, I adjust it so it requires every bus voltage to be specified.
Should be ready to merge
lukelowry
force-pushed
the
lukel/state-1
branch
from
November 11, 2026 18:16
78c19ca to
baad958
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
state_filesolver option that sets initial bus voltages from a.state.jsonfile, following #514 and #643.Proposed changes
applyStatesets busVr/Vifrom the state file by case bus number.state_filein the solver file, used by the Hawaii validation.CaseFormatTests::stateParse.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Device entries and removal of the case
initfollow in later PRs.