Repository navigation
add ieee39 case support to cosim - #651
Open
superwhiskers wants to merge 4 commits into
Open
superwhiskers wants to merge 4 commits into
superwhiskers wants to merge 4 commits into
Conversation
nkoukpaizan
approved these changes
Nov 6, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! A couple of minor comments.
pelesh
requested changes
Nov 6, 2026
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
I would separate case-specific from generic code. The file names are misleading as they are now.
I suggest for this PR to make signal connectors IDs user input. That way, we can use different models as clients and servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a partitioned ieee39 case, add support for it in the co-simulation example
Checklist
-Wall -Wpedantic -Wconversion -Wextra.