Skip to content

add ieee39 case support to cosim - #651

Open
superwhiskers wants to merge 4 commits into
developfrom
sw/ieee39-cosim
Open

superwhiskers wants to merge 4 commits into
developfrom
sw/ieee39-cosim

Conversation

@superwhiskers

Copy link
Copy Markdown
Collaborator

Description

add a partitioned ieee39 case, add support for it in the co-simulation example

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

@superwhiskers
superwhiskers requested a review from pelesh November 5, 2026 21:16
@superwhiskers superwhiskers self-assigned this Nov 5, 2026
@superwhiskers superwhiskers added the enhancement New feature or request label Nov 5, 2026

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of minor comments.

Comment thread examples/Network/CoSim/README.md Resolved
Comment thread examples/Network/CoSim/CoSimClient.cpp Resolved

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would separate case-specific from generic code. The file names are misleading as they are now.

I suggest for this PR to make signal connectors IDs user input. That way, we can use different models as clients and servers.

Comment thread examples/Network/CoSim/CoSimClient.cpp Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants