Skip to content

Run one evaluation per case in the system Jacobian ctest to shorten CI runs - #641

Merged
nkoukpaizan merged 2 commits into
developfrom
nicholson/shorten-CI
Nov 3, 2026
Merged

nkoukpaizan merged 2 commits into
developfrom
nicholson/shorten-CI

Conversation

@nkoukpaizan

Copy link
Copy Markdown
Collaborator

Description

With the new 25K and 70K cases (#634), the Jacobian benchmarks were taking too long, causing CI to timeout (e.g., https://github.com/ORNL/GridKit/actions/runs/41573592804/job/125712709373#step:15:69806). This sets the number of evaluations to 1 in ctest, the default remaining 100.

Proposed changes

  • Added a --evaluations option to runSystemJacobianTests.cpp, defaulting to 100.
  • ctest runs the benchmark with 1 evaluation.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Nov 3, 2026
@nkoukpaizan
nkoukpaizan requested review from abdourahmanbarry, lukelowry and superwhiskers and removed request for abdourahmanbarry November 3, 2026 18:46
@nkoukpaizan
nkoukpaizan marked this pull request as ready for review November 3, 2026 18:47

@lukelowry lukelowry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I wasn't sure why the tests were taking so long

@nkoukpaizan
nkoukpaizan merged commit a124b44 into develop Nov 3, 2026
7 checks passed
@nkoukpaizan
nkoukpaizan deleted the nicholson/shorten-CI branch November 3, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants