Repository navigation
Run one evaluation per case in the system Jacobian ctest to shorten CI runs - #641
Merged
Merged
Conversation
Documentation build overview
6 files changed ·
|
nkoukpaizan
requested review from
abdourahmanbarry,
lukelowry and
superwhiskers
and removed request for
abdourahmanbarry
November 3, 2026 18:46
nkoukpaizan
marked this pull request as ready for review
November 3, 2026 18:47
lukelowry
approved these changes
Nov 3, 2026
lukelowry
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, I wasn't sure why the tests were taking so long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the new 25K and 70K cases (#634), the Jacobian benchmarks were taking too long, causing CI to timeout (e.g., https://github.com/ORNL/GridKit/actions/runs/41573592804/job/125712709373#step:15:69806). This sets the number of evaluations to 1 in ctest, the default remaining 100.
Proposed changes
--evaluationsoption torunSystemJacobianTests.cpp, defaulting to 100.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments