Repository navigation
Migrate components to ParameterReader - #632
Merged
Merged
Conversation
Documentation build overview
7 files changed ·
|
lukelowry
marked this pull request as ready for review
October 28, 2026 21:52
nkoukpaizan
approved these changes
Oct 29, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Thanks for completing this migration.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the remaining PhasorDynamics models to
Model::ParameterReader, following ESDC1A from #566, to clear the way for further lambda extractions.Proposed changes
std::getreads, and the parameter error counters withParameterReader. Invalid values now throw at construction, so the affected tests useconfigurationRejected.FunctionSignalSource(string parameters) is left for a follow-up.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None.