Skip to content

Migrate components to ParameterReader - #632

Merged
nkoukpaizan merged 2 commits into
developfrom
lukel/parameter-reader-dev
Oct 29, 2026
Merged

nkoukpaizan merged 2 commits into
developfrom
lukel/parameter-reader-dev

Conversation

@lukelowry

Copy link
Copy Markdown
Collaborator

Description

Migrates the remaining PhasorDynamics models to Model::ParameterReader, following ESDC1A from #566, to clear the way for further lambda extractions.

Proposed changes

  • Replace per-model parameter lambdas, std::get reads, and the parameter error counters with ParameterReader. Invalid values now throw at construction, so the affected tests use configurationRejected.
  • FunctionSignalSource (string parameters) is left for a follow-up.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes.

Further comments

None.

@lukelowry
lukelowry marked this pull request as ready for review October 28, 2026 21:52

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for completing this migration.

@nkoukpaizan
nkoukpaizan merged commit ea5e784 into develop Oct 29, 2026
7 checks passed
@nkoukpaizan nkoukpaizan mentioned this pull request Oct 29, 2026
7 tasks done
@lukelowry
lukelowry deleted the lukel/parameter-reader-dev branch October 30, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants