Repository navigation
Separate setSignalIndices() out of evaluateResidual() - #630
Merged
Merged
Conversation
nkoukpaizan
requested review from
lukelowry and
superwhiskers
and removed request for
lukelowry
October 27, 2026 19:52
nkoukpaizan
marked this pull request as ready for review
October 27, 2026 19:52
lukelowry
approved these changes
Oct 27, 2026
lukelowry
left a comment
Collaborator
There was a problem hiding this comment.
I like this, its easier to read too. thank you! Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This separates
setSignalIndices()out ofevaluateResidual(). The latter now only reads the values. This is needed to enable sparsity analysis with Enzyme without callinginitializeandevaluateResidual.Proposed changes
setSignalIndices()with calls inallocate()and in the component-level tests.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments