Add time to region output kernels#300
Open
streeve wants to merge 1 commit into
Open
Conversation
pabloseleson
reviewed
May 1, 2026
pabloseleson
reviewed
May 1, 2026
pabloseleson
reviewed
May 1, 2026
pabloseleson
reviewed
May 1, 2026
streeve
force-pushed
the
region_output_time
branch
from
a977d5a to
da6d520
Compare
streeve
force-pushed
the
region_output_time
branch
from
da6d520 to
92461b5
Compare
Collaborator
Author
|
@pabloseleson ready for final review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks any previous case without time in the functor signature. Not sure if it's worth trying to support backwards compatibility on this (especially since this is for
OutputTimeSeries)Closes #294