test: gate lock ownership and disconnect cleanup safety - #144
Merged
Conversation
ORESoftware
marked this pull request as ready for review
August 3, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Broker1state transitions with in-process sockets.dev.Why
These ownership and cleanup paths are concurrency-critical and already have broad legacy scripts, but they were not enforced by a small deterministic pull-request gate. A regression can otherwise over-evict unrelated holders or leave dead waiters eligible for a future grant.
Validation
The workflow installs the committed lockfile without lifecycle scripts, builds both CommonJS and ESM artifacts, and runs the three contracts against the built CommonJS broker on Node 22. Each test has a five-second timeout, and every broker is closed in a
finallyblock.