Comparing fixed timestep only+failed update#7039
Open
hnil wants to merge 10 commits into
Open
Conversation
…20, but differs in pression of 1e6 due to one failer in a step.
…mestep_only+failed_update
…fference in inthead
hnil
added
the
manual:irrelevant
Member
Author
|
This will change all references and some of the resetting after failure may not be need. But this is the state of the code when replay seems to be exact up to rounding on timesteps. |
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make replay almost exact. It is checked on all model2 variants.
This also require a small change in opm-common fix_replay branch