Skip to content

moving updateFailed to problem #7006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hnil wants to merge 2 commits into from
Closed

moving updateFailed to problem #7006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d41bf5a
moving updateFailed to problem
hnil Apr 27, 2026
ab5228f
also moved advanceTimelevel
hnil Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opm/simulators/flow/BlackoilModel_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ prepareStep(const SimulatorTimerInterface& timer)
"- the previous step succeeded on some ranks but failed on others.");
}
if (lastStepFailed) {
simulator_.model().updateFailed();
simulator_.problem().updateFailed();
}
else {
simulator_.model().advanceTimeLevel();
simulator_.problem().advanceTimeLevel();
}

// Set the timestep size and episode index for the model explicitly.
Expand Down
10 changes: 10 additions & 0 deletions opm/simulators/flow/FlowProblem.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,16 @@ class FlowProblem : public GetPropType<TypeTag, Properties::BaseProblem>

}

void updateFailed()
{
this->model().updateFailed();
}

void advanceTimeLevel()
{
this->model().advanceTimeLevel();
}

/*!
* \brief Called by the simulator before each Newton-Raphson iteration.
*/
Expand Down