add GPU decorators in fluidmatrixinteractions#5144
Conversation
multitalentloes
added
the
manual:irrelevant
multitalentloes
changed the title
|
jenkins build this rocm hipify please |
atgeirr
left a comment
atgeirr
left a comment
There was a problem hiding this comment.
This can be merged when green.
With this, the GPU code can only handle the default 3-phase model and not Stone 1 or Stone 2. That is fine for now, but it is not clear to me how we will guard against that. We should stop the simulator if the user requests an unsupported option for a run on GPU instead of silently running with the default option. It is not necessary to do that in this PR, but it should be prioritized. The same applies to the LET vs normal choice.
remove empty line
|
Agree with the exception handling, I have added some error macros to handle any deviation from the exactly the physiscs that we support on the GPU |
|
jenkins build this rocm hipify please |
|
The checks will instead happen at a different layer so they do not cause overhead on a per-cell basis every time it is called. |
|
jenkins build this rocm hipify please |
2 participants
Adding GPU decorators to many files needed by #5131