Hyrax 2193#1405
Merged
Merged
Conversation
|
|
|
dh-opendap
approved these changes
Jun 30, 2026
dh-opendap
left a comment
dh-opendap
left a comment
Contributor
There was a problem hiding this comment.
Changes all seem reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-2193
When calculating the request var size of a string array, the string size is always 24. This may cause false alarm and it happens to a real file in service. This pull request will relax the calculation by always assuming the string size is 2, which is the real file case. Since string data is easy to be compressed and decompressed, the service time for a bigger string is relatively small, so we think this should be OK even for bigger string size array.
Tasks