Hyrax-2190: Upload test logs for Docker#1398
Conversation
…ld-and-test to speed things up
…he .travis.yml file knows where to look.
…o travis-test-logs
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
Look at these changes - see if the simpler docker run .... -c "..." works and if so lets use that. Else, put a comment in the Dockerfile explaining what's going on. Thanks.
| export SNAPSHOT_IMAGE_TAG="opendap/${DOCKER_NAME}:snapshot-${DIST}" | ||
| export BES_REPO_DIR=${TRAVIS_BUILD_DIR} | ||
| - ./travis/build-rhel-docker.sh | ||
| # Note: Take the test log tarball that was created in the Dockerfile and copied to the final mount |
There was a problem hiding this comment.
Maybe: and copied to the --> and copy it to the
| - ./travis/build-rhel-docker.sh | ||
| # Note: Take the test log tarball that was created in the Dockerfile and copied to the final mount | ||
| # and then run this copy command to copy it into Travis. | ||
| # Use "$1" because Single quotes prevent the host shell (Travis) from expanding ${TRAVIS_JOB_NUMBER} before invoking |
There was a problem hiding this comment.
I had to ask Claude about this pattern - the -c 'cp ...' sh "/scratch..." part.
It becomes: cp /bes-test-logs/bes-test-logs.tar.gz /scratch/bes-autotest-${TRAVIS_JOB_NUMBER}-logs.tar.gz.
The reason for the obscure
But, now that I've thought about it, I don't think we need to do that. Since the TRAVIS_JOB_NUMBER is set in/by Travis, it'll have the same value in both places. I think you can use the plain:
-c "cp /bes-test-logs/bes-test-logs.tar.gz /scratch/bes-autotest-${TRAVIS_JOB_NUMBER}-logs.tar.gz"
and it'll work (and we will know what's going on and won't have to write a huge comment. ;-)
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
This looks good.
Have you confirmed that the test log tar ball is not included in the end product bes_core image generated by Travis and used downstream?
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
I'm satisfied and we can move on.
|
|
|
3 participants
Description
Reference ticket: HYRAX-2190
TODO
Tasks