output/file: http2 metdata is logged in http object#9052
Closed
catenacyber wants to merge 1 commit into
Closed
Conversation
as is done for http2 events and alerts. The http.version integer can help to determine if this is HTTP2 Ticket: OISF#6165
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9052 +/- ##
==========================================
- Coverage 82.32% 82.29% -0.04%
==========================================
Files 969 969
Lines 273655 273655
==========================================
- Hits 225292 225204 -88
- Misses 48363 48451 +88
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 14748 |
victorjulien
requested review from
jasonish
and removed request for
a team and
victorjulien
jasonish
approved these changes
Jul 5, 2023
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
This is correct with respect changes in HTTP logging.
victorjulien
approved these changes
Jul 6, 2023
Merged
Member
|
Merged in #9168, thanks! |
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6165
Describe changes:
OISF/suricata-verify#1262
Required by #9034