Batch backports 6.0.x/1.1: Backports of 5550, 5604#8975
Closed
jlucovsky wants to merge 6 commits into
Closed
Conversation
(cherry picked from commit 0360cb6)
(cherry picked from commit 39d2524)
As UDP streams getting probed, a stream that does not appear to be DNS at first, may have a single packet that does look close enough to DNS to be picked up as DNS causing every subsequent packet to result in a parser error. To mitigate this, probe every incoming DNS message header for validity before continuing onto the body. If the header doesn't validate as DNS, just ignore the packet so no parse error is registered. (cherry picked from commit 595700a)
As part of extra header validation, split out DNS body parsing to avoid the overhead of parsing the header twice. (cherry picked from commit d720ead)
|
WARNING:
Pipeline 14269 |
Member
@ct0br0 tcp.rst and the other tcp counters should now match the numbers we use in the baseline for master. |
|
I'll rebase QA with this tonight 👍 |
jasonish
reviewed
Jun 6, 2023
Contributor
Author
|
Continued in #8985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis the pull request number.