Stats/v5#8936
Closed
victorjulien wants to merge 8 commits into
Closed
Conversation
Don't update stat from loop as it's not read until after the loop.
To reduce locking overhead in the spare pool, batch returns per 100 (spare pool block size).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8936 +/- ##
==========================================
+ Coverage 82.34% 82.38% +0.03%
==========================================
Files 969 969
Lines 273336 273386 +50
==========================================
+ Hits 225090 225226 +136
+ Misses 48246 48160 -86
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 14104 |
|
Information: QA ran without warnings. Pipeline 14107 |
Since the queue isn't fully processed every run, double counting could happen. Fix by only counting actually processed flows from the queue.
|
Information: QA ran without warnings. Pipeline 14108 |
|
WARNING:
Pipeline 14110 |
In case small blocks of flows are returned, try to merge them with existing small list head. Add full block as second in the list as with the rest of the code.
|
WARNING:
Pipeline 14113 |
|
Information: QA ran without warnings. Pipeline 14115 |
Member
Author
|
Merged in #8945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various optimizations and cleanups.