doc: GitHub PRs workflow#8913
Conversation
|
|
||
| GitHub filter is `is:pr is:open draft:true sort:updated-asc` | ||
|
|
||
| A draft may be closed if it has not been updated in the last month. |
There was a problem hiding this comment.
Idea: "A draft may be automatically closed"
We could easily script this, and I think we should at some point.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8913 +/- ##
==========================================
+ Coverage 82.30% 82.34% +0.03%
==========================================
Files 969 969
Lines 273335 273335
==========================================
+ Hits 224961 225068 +107
+ Misses 48374 48267 -107
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
One comment here, and I've added some comments to the previous PR before it was closed - https://suricata.readthedocs.io/en/latest/devguide/codebase/contributing/contribution-process.html
| GitHub PRs workflow | ||
| ====== | ||
|
|
||
| See also https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing |
There was a problem hiding this comment.
I'd rather we used the devguide version of this: https://suricata.readthedocs.io/en/latest/devguide/codebase/contributing/contribution-process.html
:)
There was a problem hiding this comment.
Indeed, I did not know this part
|
Replaced by #8920 |
3 participants
Link to redmine ticket:
None
Describe changes:
Draft : to be discussed, and I guess after merge of #8898, test if filter for approved PRs works again
Modifies #8900 by adding link to https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing