enip: convert to rust#11174
Closed
catenacyber wants to merge 1 commit into
Closed
Conversation
Ticket: 3958
- transactions are now bidirectional
- there is a logger
- gap support is improved with probing for resync
- frames support
- app-layer events
- enip_command keyword accepts now string enumeration as values.
- add enip.status keyword
- add keywords :
enip.product_name, enip.protocol_version, enip.revision,
enip.identity_status, enip.state, enip.serial, enip.product_code,
enip.device_type, enip.vendor_id, enip.capabilities,
enip.cip_attribute, enip.cip_class, enip.cip_instance,
enip.cip_status, enip.cip_extendedstatus
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11174 +/- ##
==========================================
- Coverage 84.28% 80.79% -3.50%
==========================================
Files 926 945 +19
Lines 243303 245474 +2171
==========================================
- Hits 205076 198334 -6742
- Misses 38227 47140 +8913
Flags with carried forward coverage won't be shown. Click here to find out more. |
| // These lists come from other open source programs like Wireshark, Zeek or scapy | ||
| fn enip_vendorid_string(p: u16) -> Option<&'static str> { | ||
| match p { | ||
| 1 => Some("Rockwell Automation/Allen-Bradley"), |
Member
There was a problem hiding this comment.
I think it's time for us to add a facility to load this kind of data from actual data files, instead of putting it in code. This would lead to cleaner code and it has as additional benefit that data files can be updated independently too.
Member
There was a problem hiding this comment.
|
Information: QA ran without warnings. Pipeline 20850 |
Closed
Contributor
Author
|
Continued in #11184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3958
Describe changes:
Alon the way, also
#10901 with
PduFrameHdrandDatacf doc/userguide/devguide/extending/app-layer/app-layer-frames.rstSV_BRANCH=OISF/suricata-verify#1865