Iprep feature 6857/v2#11091
Closed
victorjulien wants to merge 5 commits into
Closed
Conversation
No need to init ptrs to NULL after SCCalloc.
Implement special "isset" and "isnotset" modes. "isset" matches if an IP address is part of an iprep category with any value. It is internally implemented as ">=,0", which should always be true if there is a value to evaluate, as valid reputation values are 0-127. "isnotset" matches if an IP address is not part of an iprep category. It is internally stored as "=,255", but has some special case handling in the `DetectIPRepMatch` function. Ticket: OISF#6857.
This was referenced May 16, 2024
Closed
victorjulien
commented
May 16, 2024
| return Err(make_error("unknown category".to_string())); | ||
| } | ||
|
|
||
| if values.len() == 4 { |
|
Information: QA ran without warnings. Pipeline 20652 |
Closed
Member
Author
|
replaced by #11264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of isset and isnotset for the iprep keyword.
https://redmine.openinfosecfoundation.org/issues/6857
Replaces #11057:
Draft because: commits need to be tightened up.
SV_BRANCH=OISF/suricata-verify#1834