Skip to content

[19.0][MIG] sale_timesheet_timeline: Migration to 19.0#923

Merged
OCA-git-bot merged 10 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-sale_timesheet_timeline
Jun 11, 2026
Merged

[19.0][MIG] sale_timesheet_timeline: Migration to 19.0#923
OCA-git-bot merged 10 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-sale_timesheet_timeline

Conversation

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot OCA-git-bot added series:19.0 mod:sale_timesheet_timeline Module sale_timesheet_timeline labels May 20, 2026
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request May 20, 2026
23 tasks
@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@cgarcia-solvos could you review? Thanks!

@cgarcia-solvos cgarcia-solvos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

@cgarcia-solvos

Copy link
Copy Markdown
Contributor

The codecov fails only because the current tests only cover the scenarios where the custom fields have values. The empty states are uncovered.

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@carlos-lopez-tecnativa could you please review? Thanks!

Comment thread sale_timesheet_timeline/views/sale_order_views.xml

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration sale_timesheet_timeline
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jun 11, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-923-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ee84326 into OCA:19.0 Jun 11, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 696d20b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants