[19.0][MIG] sale_timesheet_timeline: Migration to 19.0#923
Open
BhaveshHeliconia wants to merge 10 commits into
Open
[19.0][MIG] sale_timesheet_timeline: Migration to 19.0#923BhaveshHeliconia wants to merge 10 commits into
BhaveshHeliconia wants to merge 10 commits into
Conversation
This module allows to plan in advance the start/end dates and assignees for the sales order lines that are services, and they are transferred to the created task (if any) when confirming the order. It includes a timeline view for pre-viewing and managing the planning. TT50569
23 tasks
Contributor
Author
|
@cgarcia-solvos could you review? Thanks! |
cgarcia-solvos
approved these changes
May 29, 2026
cgarcia-solvos
left a comment
Contributor
There was a problem hiding this comment.
Code review. LGTM!
Contributor
|
The codecov fails only because the current tests only cover the scenarios where the custom fields have values. The empty states are uncovered. |
Contributor
Author
|
@carlos-lopez-tecnativa could you please review? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.