[19.0][MIG] hr_timesheet_type_non_billable: Migration to 19.0#922
Open
BhaveshHeliconia wants to merge 23 commits into
Open
[19.0][MIG] hr_timesheet_type_non_billable: Migration to 19.0#922BhaveshHeliconia wants to merge 23 commits into
BhaveshHeliconia wants to merge 23 commits into
Conversation
Currently translated at 100.0% (5 of 5 strings) Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/
Currently translated at 100.0% (6 of 6 strings) Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/
OCA-git-bot
added
series:19.0
mod:hr_timesheet_type_non_billable
BhaveshHeliconia
force-pushed
the
19.0-mig-hr_timesheet_type_non_billable
branch
from
798bc63 to
52a1e80
Compare
23 tasks
Contributor
Author
|
@cgarcia-solvos could you review? Thanks! |
cgarcia-solvos
left a comment
cgarcia-solvos
left a comment
Contributor
There was a problem hiding this comment.
Code review. LGTM. Only minor comments:
BhaveshHeliconia
force-pushed
the
19.0-mig-hr_timesheet_type_non_billable
branch
from
52a1e80 to
dfa856b
Compare
Contributor
Author
|
@cgarcia-solvos I've addressed your suggestion. Thanks for the review! |
cgarcia-solvos
approved these changes
Jun 1, 2026
Contributor
Author
|
@bosd Could you please review? |
Contributor
|
I'm not so familiar yet with this module. my functional test failed. When i create a bill from the SO. An invoice is created with 1 hour of billable time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.