[MIG] hr_employee_cost_history : Migration to 19.0.#914
Conversation
OCA-git-bot
added
series:19.0
mod:hr_employee_cost_history
uncannycs
force-pushed
the
19.0-mig-hr_employee_cost_history
branch
from
39514d4 to
923a985
Compare
…roactively in timesheets This module allows to modify retroactively timesheet costs from a given date and store those changes in a new model. @moduon MT-4266
Currently translated at 91.6% (22 of 24 strings) Translation: timesheet-18.0/timesheet-18.0-hr_employee_cost_history Translate-URL: https://translation.odoo-community.org/projects/timesheet-18-0/timesheet-18-0-hr_employee_cost_history/es/
Currently translated at 100.0% (24 of 24 strings) Translation: timesheet-18.0/timesheet-18.0-hr_employee_cost_history Translate-URL: https://translation.odoo-community.org/projects/timesheet-18-0/timesheet-18-0-hr_employee_cost_history/es/
uncannycs
force-pushed
the
19.0-mig-hr_employee_cost_history
branch
from
923a985 to
9a9b4c0
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional and code review LGTM!
uncannycs
force-pushed
the
19.0-mig-hr_employee_cost_history
branch
from
c9a48b0 to
3c76d1b
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Could we use BaseCommon instead of TransactionCase? In that case, there would be no need to redefine cls.env with tracking_disable=True.
|
This PR has the |
chienandalu
left a comment
chienandalu
left a comment
There was a problem hiding this comment.
On first sight code review
Shide
left a comment
Shide
left a comment
There was a problem hiding this comment.
If you add a future hourly cost. This directly appears into the employee.
Should be great to add this to ROADMAP.md or to fix this behavior.
Functional and technical review.
Approving because the module works in this way.
|
Hello @uncannycs , could you please attend comments from @chienandalu ? Are you going to continue with this PR? Thank you! |
|
/ocabot migration hr_employee_cost_history |
|
Sorry @rafaelbn you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
uncannycs
force-pushed
the
19.0-mig-hr_employee_cost_history
branch
from
82688f0 to
926e127
Compare
Yes, we have resolve the comments. |
11 participants
No description provided.