[16.0][FIX] fs_attachment: Delay base_url_for_files recompute at end of reg…#628
Open
lmignon wants to merge 1 commit into
Open
[16.0][FIX] fs_attachment: Delay base_url_for_files recompute at end of reg…#628lmignon wants to merge 1 commit into
lmignon wants to merge 1 commit into
Conversation
…istry initialization This is required to ensure that all the addons are fully loaded when the recompute occurs
Contributor
Author
Member
|
Sorry, but I think the dependency should be removed ASAP, as it's not adding value, but conditioning things and provoking incompatibilities in systems not using them, and you can see that the migration script will handle the case where you need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix problem reported in #614