Skip to content

[18.0][ADD] shoppingfeed_integration#1

Open
juancarlosonate-tecnativa wants to merge 27 commits into
OCA:18.0from
Tecnativa:18.0-add-shoppingfeed_integration
Open

[18.0][ADD] shoppingfeed_integration#1
juancarlosonate-tecnativa wants to merge 27 commits into
OCA:18.0from
Tecnativa:18.0-add-shoppingfeed_integration

Conversation

@juancarlosonate-tecnativa

@juancarlosonate-tecnativa juancarlosonate-tecnativa commented Nov 11, 2025

Copy link
Copy Markdown

@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 4 times, most recently from 5c92337 to ea1328e Compare November 26, 2025 18:17
@juancarlosonate-tecnativa

Copy link
Copy Markdown
Author

Could you take a look when you have some time, please? @christian-ramos-tecnativa @carlos-lopez-tecnativa @eduezerouali-tecnativa

@juancarlosonate-tecnativa juancarlosonate-tecnativa marked this pull request as draft December 1, 2025 18:17

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! It's a major module, so I haven't finished testing it yet, but there are a couple of aspects that could be improved

Comment thread shoppingfeed_integration/controllers/catalog.py
Comment thread shoppingfeed_integration/security/ir.model.access.csv Outdated
Comment thread shoppingfeed_integration/views/shoppingfeed_store_views.xml Outdated
Comment thread shoppingfeed_integration/views/shoppingfeed_store_views.xml Outdated
Comment thread shoppingfeed_integration/models/stock_picking.py Outdated
"will be exported with quantity 0."
),
)
update_quantities_realtime = fields.Boolean(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the stock related fields I was missing a warehouse filtering. So I could for example specify different warehouses for different shoppingfeed stores. WDYT

]
)
)
for product in self.filtered("default_code"):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are always taking the product default_code as reference, but shouldn't you check the reference used in the store? The fields use_product_id_as_sku and custom_sku_field_id at shoppingfeed.store model

Comment thread shoppingfeed_integration/models/shoppingfeed_ticket.py
Comment thread shoppingfeed_integration/models/shoppingfeed_ticket.py
Comment thread shoppingfeed_integration/models/shoppingfeed_store.py Outdated
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 4 times, most recently from f4cc37c to f7cb778 Compare December 10, 2025 16:38
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch from f7cb778 to 4fabc67 Compare December 17, 2025 16:23
Comment thread shoppingfeed_integration/views/shoppingfeed_ticket_views.xml
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 3 times, most recently from b0394aa to 9dfdfea Compare January 14, 2026 12:43

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Comment thread shoppingfeed_integration/data/cron.xml Outdated
Comment thread shoppingfeed_integration/models/account_move.py Outdated
Comment thread shoppingfeed_integration/models/product_product.py Outdated
Comment thread shoppingfeed_integration/models/sale_order.py Outdated
Comment thread shoppingfeed_integration/models/sale_order.py Outdated
Comment thread shoppingfeed_integration/views/menus.xml
Comment thread shoppingfeed_integration/views/menus.xml
Comment thread shoppingfeed_integration/models/sale_order.py
Comment thread shoppingfeed_integration/models/sale_order.py
Comment thread shoppingfeed_integration/views/sale_order_views.xml
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 2 times, most recently from 8178d9b to 2aa1193 Compare January 19, 2026 17:39
Comment thread shoppingfeed_integration/models/sale_order.py Outdated
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 6 times, most recently from e3aa9a1 to d2eb756 Compare January 26, 2026 13:10
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 4 times, most recently from 0c3de7d to fc1f3bd Compare February 2, 2026 17:56
@sergio-teruel sergio-teruel force-pushed the 18.0-add-shoppingfeed_integration branch from d1aed44 to 70a5508 Compare May 18, 2026 09:58
carlos-lopez-tecnativa and others added 4 commits May 18, 2026 10:06
Comment thread shoppingfeed_integration/models/sale_order.py Outdated
@sergio-teruel sergio-teruel force-pushed the 18.0-add-shoppingfeed_integration branch from 1691d60 to 5f54dcf Compare May 19, 2026 10:46
sergio-teruel and others added 5 commits May 19, 2026 13:31
…e to many2many in store carrier mappings

With this change, for each mapping line the user can configure multiple carriers, and the logic selects the first one that matches the shipping address.

For example, the customer buys from the Spain store, but the delivery address is in another country.
@carlosdauden carlosdauden force-pushed the 18.0-add-shoppingfeed_integration branch 2 times, most recently from 44e22b8 to 38edbfb Compare May 22, 2026 10:30
Method _shoppingfeed_format_phone called without order and _phone_format has ensure_one
TT62646
@carlosdauden carlosdauden force-pushed the 18.0-add-shoppingfeed_integration branch from 38edbfb to 680bc80 Compare May 22, 2026 10:38
… number is set

Before this commit, the formatting was never performed because self was always empty. In this commit:
OCA@44e22b8

the code was changed to skip formatting when self is empty, but self is always empty in this case.

This commit fixes the code to perform the formatting only when the phone field is set; if it is empty, the formatting is skipped.
https://github.com/odoo/odoo/blob/74995277d6817103ae1816e4653e81460c3daf56/addons/phone_validation/models/models.py#L74
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch from 8cf9af1 to 1b3f972 Compare May 28, 2026 14:11
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-add-shoppingfeed_integration branch 2 times, most recently from 1b3f972 to 2907d8b Compare May 28, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:shoppingfeed_integration Module shoppingfeed_integration series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants