Skip to content

[18.0][FIX] product_variant_sale_price: fix double UoM calculations#438

Open
LuvForAirplanes wants to merge 1 commit into
OCA:18.0from
LuvForAirplanes:18.0
Open

[18.0][FIX] product_variant_sale_price: fix double UoM calculations#438
LuvForAirplanes wants to merge 1 commit into
OCA:18.0from
LuvForAirplanes:18.0

Conversation

@LuvForAirplanes

Copy link
Copy Markdown

Fix issue where changing the quantity on a sales order line after the UoM had been changed resulted in a double UoM conversion. To re-produce:

  1. Create a new sales order and add a line item with, for example, Gal as the UoM
  2. Change the UoM to Quart
  3. Attempt to update the quantity. The price will be double UoM converted, thus causing the it to drop drastically from the correct price.

The last time this code was touched was 9 years ago. I believe Odoo since added this as a standard feature.

Fix issue where changing the quantity on a sales order line after the UoM had been changed resulted in a double UoM conversion
@LuvForAirplanes

Copy link
Copy Markdown
Author

Actually, I believe this was attempted several times before:
#343 #259 #54

@LuvForAirplanes

Copy link
Copy Markdown
Author

@pedrobaeza Can we get this merged?

@pedrobaeza pedrobaeza changed the title [FIX] product_variant_sale_price: fix double UoM calculations [18.0][FIX] product_variant_sale_price: fix double UoM calculations Apr 6, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

@LuvForAirplanes

Copy link
Copy Markdown
Author

@OCA/core-maintainers I am looking for a review.

@LuvForAirplanes

Copy link
Copy Markdown
Author

@pedrobaeza how do I get reviews?

@pedrobaeza pedrobaeza added this to the 18.0 milestone Apr 27, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

You can ask PSC or module maintainer, and do reviews of other PRs to get traction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants