[18.0][FIX] product_variant_sale_price: fix double UoM calculations#438
Open
LuvForAirplanes wants to merge 1 commit into
Open
[18.0][FIX] product_variant_sale_price: fix double UoM calculations#438LuvForAirplanes wants to merge 1 commit into
LuvForAirplanes wants to merge 1 commit into
Conversation
Fix issue where changing the quantity on a sales order line after the UoM had been changed resulted in a double UoM conversion
Author
Author
|
@pedrobaeza Can we get this merged? |
Member
Author
|
@OCA/core-maintainers I am looking for a review. |
Author
|
@pedrobaeza how do I get reviews? |
Member
|
You can ask PSC or module maintainer, and do reviews of other PRs to get traction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where changing the quantity on a sales order line after the UoM had been changed resulted in a double UoM conversion. To re-produce:
The last time this code was touched was 9 years ago. I believe Odoo since added this as a standard feature.