Skip to content

[18.0][ADD] product_variant_search#433

Open
AungKoKoLin1997 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-product_variant_search
Open

[18.0][ADD] product_variant_search#433
AungKoKoLin1997 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-product_variant_search

Conversation

@AungKoKoLin1997

Copy link
Copy Markdown

Supersedes OCA/product-attribute#2196
This module improves product variant searching by matching the product display name across all product selection fields.

@qrtl QT6354

Comment thread product_variant_search/models/product_attribute_value.py Outdated
Comment thread product_variant_search/models/product_product.py Outdated
Comment thread product_variant_search/models/product_product.py Outdated
Comment thread product_variant_search/models/product_product.py Outdated
Comment thread product_variant_search/models/product_product.py
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-product_variant_search branch from 88931bb to 41caa7d Compare February 2, 2026 05:16
Comment thread product_variant_search/models/product_attribute_value.py Outdated
Comment thread product_variant_search/hooks.py
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-product_variant_search branch 6 times, most recently from 3438aaa to 210943c Compare February 4, 2026 03:13
Comment thread product_variant_search/data/ir_cron.xml Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-product_variant_search branch from 210943c to cc5c875 Compare February 4, 2026 06:48

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Comment thread product_variant_search/readme/DESCRIPTION.md Outdated
Comment thread product_variant_search/readme/INSTALL.md

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional review: LGTM

I have confirmed that in a multi-language environment, product variants can be searched using attribute values in each respective language.

I have also confirmed that when the user’s language is set to English, searching with Japanese attribute values does not return the corresponding product variants in the search results.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-product_variant_search branch from cc5c875 to 32614f8 Compare February 5, 2026 06:12

@smorita7749 smorita7749 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM
Create a product with the following fields:

Product name: Desk
Attribute: Color
Values: Wood, Black

When searching for "Wood" in the product section field, the product variant "Desk (Wood)" is displayed.
When searching for "Desk (Black)" in the product section field, the targeted product variant is displayed.

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft May 19, 2026 01:17
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review May 25, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants