Skip to content

[18.0][MIG] product_matrix_show_color#422

Open
ferran-S73 wants to merge 7 commits into
OCA:18.0from
Studio73:18.0-mig-product_matrix_show_color
Open

[18.0][MIG] product_matrix_show_color#422
ferran-S73 wants to merge 7 commits into
OCA:18.0from
Studio73:18.0-mig-product_matrix_show_color

Conversation

@ferran-S73

Copy link
Copy Markdown

Migration from #289

@ferran-S73 ferran-S73 force-pushed the 18.0-mig-product_matrix_show_color branch 4 times, most recently from 1b4d45b to 30f6d12 Compare October 28, 2025 11:31

@Reyes4711-S73 Reyes4711-S73 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenios73 eugenios73 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@ferran-S73

Copy link
Copy Markdown
Author

@OCA/product-maintainers I'll need some help with this PR's tests if anyone could help me I'd be very thankful.

Context:
Both base modules "product" and "product_matrix" create a product.attribute with the name "Size".
The problem is the module "product_variant_default_code" from this repo implements a constraint on unique attributes name. Then since this module depends on both product and product_matrix and error is thrown when trying to create the constrain as there's already a repeat in attribute's names.

Is there anything we can do in this situation?

@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@ferran-S73 ferran-S73 force-pushed the 18.0-mig-product_matrix_show_color branch from 73ae3d5 to 132fc63 Compare March 9, 2026 10:41
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants