Skip to content

[16.0][FIX]product_variant_default_code: prevent default code computation f…#417

Open
flotho wants to merge 1 commit into
OCA:16.0from
flotho:FIX-product-variant-default-code-init-existing-products
Open

[16.0][FIX]product_variant_default_code: prevent default code computation f…#417
flotho wants to merge 1 commit into
OCA:16.0from
flotho:FIX-product-variant-default-code-init-existing-products

Conversation

@flotho

@flotho flotho commented Sep 23, 2025

Copy link
Copy Markdown
Member

…or legacy products

When your database has many products, the installaation of this module was recomputing all the default code on existing products. Setting the manual_code value to True on legacy products prevent this behaviour

@OCA-git-bot

OCA-git-bot commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Hi @Kev-Roche,
some modules you are maintaining are being modified, check this out!

@flotho flotho changed the title [FIX]product_variant_default_code: prevent default code computation f… [16.0][FIX]product_variant_default_code: prevent default code computation f… Sep 23, 2025
@flotho

flotho commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

ping @DorianMAG @JulienMartinez

@flotho

flotho commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

ping @OCA/product-maintainers any chance to have a review for this fix ?

DorianMAG
DorianMAG approved these changes Sep 24, 2025
View reviewed changes

@DorianMAG DorianMAG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Jan 25, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
JulienMartinez
JulienMartinez approved these changes Jan 26, 2026
View reviewed changes

@JulienMartinez JulienMartinez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flotho
[FIX]product_variant_default_code: prevent default code computation f…
3186dee 
…or legacy products

When your database has many products, the installaation of this module was recomputing all the default code on existing products.
Setting the manual_code value to True on legacy products prevent this behaviour
@flotho flotho force-pushed the FIX-product-variant-default-code-init-existing-products branch from ff27407 to 3186dee Compare January 26, 2026 14:38
@flotho

flotho commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

Hi @Kev-Roche , any chance to have a review on this one ?
regarsd

Kev-Roche
Kev-Roche approved these changes Jan 26, 2026
View reviewed changes

@Kev-Roche Kev-Roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 1, 2026
@flotho

flotho commented Feb 22, 2026

Copy link
Copy Markdown
Member Author

ping @OCA/product-maintainers any chance to be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Kev-Roche Kev-Roche Kev-Roche approved these changes

@JulienMartinez JulienMartinez JulienMartinez approved these changes

@DorianMAG DorianMAG DorianMAG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flotho @OCA-git-bot @Kev-Roche @JulienMartinez @DorianMAG