[14.0][FIX] sale_commission_product_criteria: Get items without commission

[SirPyTech]

Backporting 2 small PRs from 16.0: #615 and #619.
@Tisho99, @ValentinVinagre and @manuelregidor thanks for your work on those PRs!
Maybe you want to have a look?

---

I have also a dded a fix for method _get_commission_items: unfortunately I don't know ho to reproduce it from the UI, but calling the method with an empty commission raises:

ERROR: operator does not exist: integer = boolean
LINE 9:             AND (item.commission_id = false)
                                            ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts

See the added test for more details.

[OCA-git-bot]

Hi @PicchiSeba, @renda-dev, @aleuffre, @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

[Tisho99]

LGTM. Code review. ¿Could you add the version to the PR title?

[SirPyTech]

LGTM. Code review. ¿Could you add the version to the PR title?

Thanks for the review!
I usually don't add it because it feels redundant, but here I added it to thank you for the approval 😉

[ValentinVinagre]

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

[SirPyTech]

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗
Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

[ValentinVinagre]

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗 Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

No problem 😸 . You should ping the repository's psc's; they're the ones who maintain the whole ecosystem.

[SirPyTech]

@SirPyTech We don't review things from older versions. Sorry for the inconvenience. Next time, please don't ping two people from the same company. Thanks.

Thanks for the feedback anyway 🤗 Sorry for the noise, as you know it's hard to get reviews in the OCA so I usually ping whoever might be interested.

No problem 😸 . You should ping the repository's psc's; they're the ones who maintain the whole ecosystem.

I usually bother the PSC only when the PR has enough reviews.

[HekkiMelody]

Code review, LGTM. Thanks for the fixes!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[SirPyTech]

@OCA/crm-sales-marketing-maintainers this backporting already has 2 approvals, can someone have a look? Thanks!