Skip to content

Fix 1Password save-login popup on every navigation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hienqn wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

Fix 1Password save-login popup on every navigation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion prompt-pantry-app/src/components/AdminPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ const CreateUserModal: React.FC<CreateUserModalProps> = ({isOpen, onClose, onSav
<div className="fixed inset-0 bg-black/50 flex items-center justify-center z-50">
<div className="bg-white dark:bg-gray-800 rounded-lg shadow-xl p-6 w-full max-w-md">
<h2 className="text-xl font-bold text-gray-900 dark:text-gray-100 mb-4">Create New User</h2>
<form onSubmit={handleSubmit} className="space-y-4">
<form onSubmit={handleSubmit} className="space-y-4" autoComplete="off">
<div>
<label htmlFor="new-username" className="block text-sm font-medium text-gray-700 dark:text-gray-300 mb-1">
Username
Expand All @@ -407,6 +407,8 @@ const CreateUserModal: React.FC<CreateUserModalProps> = ({isOpen, onClose, onSav
ref={usernameInputRef}
id="new-username"
type="text"
autoComplete="off"
data-1p-ignore
value={username}
onChange={(e) => setUsername(e.target.value)}
className="w-full px-3 py-2 border border-gray-300 dark:border-gray-600 rounded-md shadow-sm focus:ring-indigo-500 focus:border-indigo-500 dark:bg-gray-700 dark:text-gray-100"
Expand All @@ -421,6 +423,8 @@ const CreateUserModal: React.FC<CreateUserModalProps> = ({isOpen, onClose, onSav
<input
id="new-password"
type="password"
autoComplete="off"
data-1p-ignore
value={password}
onChange={(e) => setPassword(e.target.value)}
className="w-full px-3 py-2 border border-gray-300 dark:border-gray-600 rounded-md shadow-sm focus:ring-indigo-500 focus:border-indigo-500 dark:bg-gray-700 dark:text-gray-100"
Expand Down
2 changes: 2 additions & 0 deletions prompt-pantry-app/src/components/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export const Login: React.FC<LoginProps> = ({onLogin}) => {
<input
id="username"
type="text"
autoComplete="username"
required
value={username}
onChange={(e) => setUsername(e.target.value)}
Expand All @@ -97,6 +98,7 @@ export const Login: React.FC<LoginProps> = ({onLogin}) => {
<input
id="password"
type="password"
autoComplete="current-password"
required
value={password}
onChange={(e) => setPassword(e.target.value)}
Expand Down