[fix] Enforce trajectory start rate after waiting for concurrency - #2169
Closed
jxucoder wants to merge 1 commit into
Closed
[fix] Enforce trajectory start rate after waiting for concurrency#2169jxucoder wants to merge 1 commit into
jxucoder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rate and concurrency limits are enabled together, queued trials consume rate tokens before waiting for a concurrency slot. After a long-running trial finishes, they can start in a burst beyond the token bucket's allowed start rate.
For example, with
rate=1andmax_concurrency=1, two trials queue at t=1 and t=2 behind an occupied slot. When the slot is released at t=2, both can start at t=2 instead of the second waiting for another token.Reserve a concurrency slot before acquiring a rate token, and release that slot if the rate-token wait fails or is cancelled. Add a simulated-clock regression for queued start bursts and tests for cancellation at both waiting stages. Rename the existing combined-limit test to match the behavior it checks.
Validation:
git diff --checkpass for the changed files.The tests ran on macOS/Python 3.12 using an isolated harness that loads the actual limiter module at its canonical import name and disables parent conftest loading, bypassing unrelated training imports and the Ray fixture. Standard project-environment validation and Harbor end-to-end validation are still pending.