Skip to content

fix(tinker): align forwarding pool deadline #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hershg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tinker): align forwarding pool deadline #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skyrl/tinker/extra/skyrl_train_inference_forwarding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, engine_config: EngineConfig, db_engine):
connect=10.0,
read=engine_config.forwarding_inference_timeout_sec,
write=300.0,
pool=300.0,
pool=engine_config.forwarding_inference_timeout_sec,
),
limits=httpx.Limits(
max_connections=max_conn,
Expand Down
4 changes: 2 additions & 2 deletions tests/tinker/test_inference_forwarding_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_forwarding_timeout_reads_environment(monkeypatch) -> None:
assert config.forwarding_inference_timeout_sec == 1800.0


def test_forwarding_client_uses_configured_timeout() -> None:
def test_forwarding_client_uses_configured_read_and_pool_timeout() -> None:
config = EngineConfig(
base_model="test-model",
forwarding_inference_timeout_sec=1800.0,
Expand All @@ -34,7 +34,7 @@ def test_forwarding_client_uses_configured_timeout() -> None:
assert timeout.connect == 10.0
assert timeout.read == 1800.0
assert timeout.write == 300.0
assert timeout.pool == 300.0
assert timeout.pool == 1800.0


@pytest.mark.asyncio
Expand Down
Loading