[ci] Keep skipped label-gated runs from masking live GPU CI - #2110
Merged
erictang000 merged 1 commit intoSep 1, 2026
Merged
Conversation
A `labeled` event starts a run of every workflow triggered on `labeled`, whatever the label was -- applying three labels to NovaSky-AI#1898 produced 15 runs, of which 3 did work. The other 12 skip, which is correct, but they published their skip under the same check name as the real run. GitHub keeps only the newest check of a given name, so whether a live suite showed as running came down to whether its own run happened to be created last. Two of the three running suites reported "skipped" on the PR. Name the job by whether it is going to run, so a skip lands on its own check context and can only ever supersede another skip. The running branch is the job id -- the existing context name -- so any branch protection pointing at it is unaffected.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
labeledevent starts a run of every workflow triggered onlabeled, whatever the label was -- applying three labels to #1898 produced 15 runs, of which 3 did work. The other 12 skip, which is correct, but they published their skip under the same check name as the real run. GitHub keeps only the newest check of a given name, so whether a live suite showed as running came down to whether its own run happened to be created last. Two of the three running suites reported "skipped" on the PR.Name the job by whether it is going to run, so a skip lands on its own check context and can only ever supersede another skip. The running branch is the job id -- the existing context name -- so any branch protection pointing at it is unaffected.