added check to enforce start date#4164
Merged
Merged
Conversation
wavehassman
approved these changes
Jun 8, 2026
Contributor
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
very nice! used this pr to also make some bug fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added an if statement that raises an error if the start date is after the deadline. The if statement also checks if there is a start or end date so it doesn't raise an error if you create a project without a start or end.
Notes
I'm still not sure if I did postman correct, I tried my best and it seems like it works
Test Cases
Case 1: Start date before deadline. No error raised
Case 2: Start date after deadline. Error raised
Case 3: Start date on the deadline. No error raised
Closes #3934