[tfausak]

I'm the author of Cabal Gild. This PR adds me as a maintainer alongside @turion (from #299962) and adds cabal-gild as a top-level attribute.

Assisted-by: Claude Code (Claude Opus 5.5) was used to research how Haskell packages are exposed in nixpkgs and draft the commits. I reviewed all changes and built cabal-gild locally on aarch64-darwin.

Things done

• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.
• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • aarch64-darwin
• Tested, as applicable:
  • Basic functionality of all binary files, usually in ./result/bin/.
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Package tests at passthru.tests.
  • NixOS tests in nixos/tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.

[turion]

Great that you want to add it! (And thanks for your work on it btw.) If possible, let's simplify it to a oneliner.

[sternenseemann]

Please run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh --fast from the top level of nixpkgs to reflect the maintainer changes in the main package set.

[tfausak]

The regenerate-hackage-packages.sh script did not work for me on macOS. I manually applied the edits that I thought it would make.

[turion]

I ran regenerate-hackage-packages.sh on your PR, it had no changes in the places you edited:

❯ git diff

pkgs/development/haskell-modules/hackage-packages.nix
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

───────────────┐
18025: self: { │
───────────────┘
      description = "HFuse is a binding for the Linux FUSE library";
      license = lib.licenses.bsd3;
      platforms = lib.platforms.linux;
      hydraPlatforms = lib.platforms.none;
      broken = true;
    }
  ) { inherit (pkgs) fuse; };

────────────────┐
432844: self: { │
────────────────┘
      )
      {
        c10 = null;
        torch = null;
        inherit (pkgs) torch;
        torch_cpu = null;
      };


────────────────┐
446861: self: { │
────────────────┘
    {
      mkDerivation,
      base,
      lua5_4,
      lua,
      tasty,
      tasty-hunit,
    }:

────────────────┐
446874: self: { │
────────────────┘
        "-f-use-pkgconfig"
      ];
      libraryHaskellDepends = [ base ];
      librarySystemDepends = [ lua5_4 ];
      librarySystemDepends = [ lua ];
      testHaskellDepends = [
        base
        tasty

────────────────┐
446883: self: { │
────────────────┘
      description = "Lua, an embeddable scripting language";
      license = lib.meta.getLicenseFromSpdxId "MIT";
    }
  ) { inherit (pkgs) lua5_4; };
  ) { lua = null; };

  lua-arbitrary = callPackage (
    {

[turion]

I think I can't override the CI failure when trying to merge. Maybe it makes sense to merge into haskell-updates. Or we wait until the haskell builder is fixed and rebase.

[tfausak]

I re-added the overrides. I'm happy to remove them when they're no longer necessary. I'd prefer to avoid waiting for some big refactor of Haskell packages though.

[sternenseemann]

This solution is strictly worse since using overrideAttrs makes later overrideCabal revert those changes which can be problematic.

[sternenseemann]

@turion I thought commiters can ignore the check. Maybe you need to dismiss your old review first.

[tfausak]

I'm happy to include the overrides or leave them out. I really don't care. It's a bit annoying to go back and forth like this.

using overrideAttrs makes later overrideCabal revert those changes

I am not a Nix person, but Claude tested overrideCabal and it seemed to work as expected:

haskell.lib.compose.overrideCabal (o: { doCheck = false; }) cabal-gild
# => strictDeps = true, __structuredAttrs = true, doCheck = false

Very possible that I'm missing something or misunderstood though.