various: migrate toPythonApplication entires to by-name#519258
Closed
phanirithvij wants to merge 6 commits into
Closed
various: migrate toPythonApplication entires to by-name#519258phanirithvij wants to merge 6 commits into
phanirithvij wants to merge 6 commits into
Conversation
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
phanirithvij
marked this pull request as ready for review
May 12, 2026 06:57
This comment was marked as outdated.
This comment was marked as outdated.
nixpkgs-ci
Bot
added
the
9.needs: reviewer
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
vcunat
removed their request for review
May 13, 2026 06:59
Member
|
I lack mental capacity. |
Member
|
it's a significant change for the python ecosystem so I leave the review to some top-level python maintainer (I am not sure who sry) |
teto
removed their request for review
May 14, 2026 12:48
nixpkgs-ci
Bot
added
the
2.status: merge conflict
Contributor
|
See also #487808 |
phanirithvij
force-pushed
the
by-name-python-applications
branch
from
May 14, 2026 17:46
92ba832 to
13708c2
Compare
nixpkgs-ci
Bot
removed
the
2.status: merge conflict
Member
Author
|
Nice find, I will continue this pr as that seems a bit outdated. |
phanirithvij
requested review from
Sigmanificient and
natsukium
and removed request for
Prince213
May 14, 2026 18:10
13 tasks
Sigmanificient
left a comment
Sigmanificient
left a comment
Member
There was a problem hiding this comment.
I recall some vague discussion about this, were there was another option that could be better, which is why i left mine in draft.
Ugh honestly it's going to be hard to dig for it 😅
phanirithvij
force-pushed
the
by-name-python-applications
branch
from
May 16, 2026 06:51
13708c2 to
b4cccc8
Compare
phanirithvij
marked this pull request as draft
May 16, 2026 06:51
phanirithvij
marked this pull request as ready for review
May 16, 2026 07:17
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
by-name-python-applications
branch
from
May 16, 2026 09:06
b4cccc8 to
2937e2a
Compare
Member
Author
|
Once reviewed I will squash them all into a single commit. |
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
by-name-python-applications
branch
from
May 16, 2026 09:25
2937e2a to
5e356b2
Compare
phanirithvij
changed the title
Member
Author
|
I saw your comment @dotlambda #514227 (comment), could you maybe clarify what @Sigmanificient said in this thread above. |
Member
Author
|
Ok I found this #454559 (comment) And given few other prs doing the same I am closing mine. Sorry for the spam pr and for not looking for the previous efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial migration done with the help of a script generated by LLM. (Link to gist)
Then manually went through nixpkgs-review to fix any breakages.
And manually migrated the remaining 5 or 6 packages.
Things done
passthru.tests.functionality.
nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.other READMEs.