Skip to content

aliases: normalize "# added" comment#456324

Closed
Sigmanificient wants to merge 1 commit into
NixOS:masterfrom
Sigmanificient:aliases-cleanup
Closed

aliases: normalize "# added" comment#456324
Sigmanificient wants to merge 1 commit into
NixOS:masterfrom
Sigmanificient:aliases-cleanup

Conversation

@Sigmanificient

Copy link
Copy Markdown
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient

Sigmanificient commented Oct 27, 2025

Copy link
Copy Markdown
Member Author

@wolfgangwalther Hi, do you think this is worth it? Should i also look into further normalization (trailing dot, quotes) and should this be documented somewhere?

Wanted to have your input on theses questions after looking at #455735, and made this draft (simple sed replacement for now)

@Sigmanificient Sigmanificient changed the title aliases: normalize added comment aliases: normalize "# added" comment Oct 27, 2025
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 27, 2025
@wolfgangwalther

Copy link
Copy Markdown
Contributor

Any such cleanup should be based on #456065, which I intend to review and merge within the next hours. From looking at that PR, I think the script can deal with both lower and uppercase here, so I don't think we actually need this change.

@Sigmanificient

Copy link
Copy Markdown
Member Author

I think working on getting them consistent and notmalized would still be a nice thing

@wolfgangwalther

Copy link
Copy Markdown
Contributor

Well, we are working to get rid of them all, via #442066 (work ongoing, even though the PR is silent right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants