aliases: normalize "# added" comment#456324
Closed
Sigmanificient wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@wolfgangwalther Hi, do you think this is worth it? Should i also look into further normalization (trailing dot, quotes) and should this be documented somewhere? Wanted to have your input on theses questions after looking at #455735, and made this draft (simple |
Contributor
|
Any such cleanup should be based on #456065, which I intend to review and merge within the next hours. From looking at that PR, I think the script can deal with both lower and uppercase here, so I don't think we actually need this change. |
Member
Author
|
I think working on getting them consistent and notmalized would still be a nice thing |
Contributor
|
Well, we are working to get rid of them all, via #442066 (work ongoing, even though the PR is silent right now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.