Skip to content

typstfmt: drop#455686

Merged
SigmaSquadron merged 1 commit into
NixOS:masterfrom
chillcicada:drop/typstfmt
Nov 5, 2025
Merged

typstfmt: drop#455686
SigmaSquadron merged 1 commit into
NixOS:masterfrom
chillcicada:drop/typstfmt

Conversation

@chillcicada

@chillcicada chillcicada commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

The upstream of typstfmt was archived in Jun 2024 and is no longer maintained. Considering that typstfmt struggles with the updates of typst, I am unsure whether typstfmt still work, but removal is the best.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 26, 2025
@nix-owners
nix-owners Bot requested review from figsoda and geri1701 October 26, 2025 01:41
@mdaniels5757 mdaniels5757 added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 26, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 26, 2025
pyrox0
pyrox0 reviewed Oct 27, 2025
View reviewed changes
Comment thread pkgs/top-level/aliases.nix Outdated
@pyrox0

pyrox0 commented Oct 27, 2025

Copy link
Copy Markdown
Member

Please resolve the conflicts and then this is good to merge!

@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 27, 2025
@elfenermarcell elfenermarcell mentioned this pull request Nov 4, 2025
Open
eclairevoyant
eclairevoyant suggested changes Nov 4, 2025
View reviewed changes

@eclairevoyant eclairevoyant left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in nixpkgs we should rebase rather than merging. And we don't use conventional commits (chore: ...) because nixpkgs CI will try to build whatever comes before the :. Just use one commit to drop the package.

@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 4, 2025
@chillcicada

chillcicada commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I noticed that typst-fmt has been converted to throw in #456065 as below, do i need to modify/remove it?

typst-fmt = throw "'typst-fmt' has been renamed to/replaced by 'typstfmt'"; # Converted to throw 2025-10-27

@pyrox0

pyrox0 commented Nov 4, 2025

Copy link
Copy Markdown
Member

I noticed that typst-fmt has been converted to throw in #456065 as below, do i need to modify/remove it?

typst-fmt = throw "'typst-fmt' has been renamed to/replaced by 'typstfmt'"; # Converted to throw 2025-10-27

yes, either change the wording or make it point to typstfmt's throw

@chillcicada

chillcicada commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

i set typst-fmt point to typstfmt

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 4, 2025
@pyrox0

pyrox0 commented Nov 4, 2025

Copy link
Copy Markdown
Member

Changes LGTM now.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Nov 4, 2025
SigmaSquadron
SigmaSquadron requested changes Nov 5, 2025
View reviewed changes
Comment thread pkgs/top-level/aliases.nix Outdated
@SigmaSquadron SigmaSquadron reopened this Nov 5, 2025
@SigmaSquadron
SigmaSquadron added this pull request to the merge queue Nov 5, 2025
Merged via the queue into NixOS:master with commit 9aced17 Nov 5, 2025
56 of 63 checks passed
@chillcicada
chillcicada deleted the drop/typstfmt branch November 5, 2025 11:55
ryota2357 added a commit to ryota2357/treefmt-nix that referenced this pull request Dec 1, 2025
@ryota2357
feat!: remove typstfmt
1f9d524 
error: 'typstfmt' has been removed due to lack of upstream maintenance, consider using 'typstyle' instead.
ref: NixOS/nixpkgs#455686
@ryota2357 ryota2357 mentioned this pull request Dec 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrox0 pyrox0 pyrox0 approved these changes
@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes
@figsoda figsoda Awaiting requested review from figsoda
+2 more reviewers
@eclairevoyant eclairevoyant eclairevoyant approved these changes
@geri1701 geri1701 geri1701 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chillcicada @pyrox0 @eclairevoyant @geri1701 @SigmaSquadron @mdaniels5757