Skip to content

netlify-cli: Fix eval for utillinux alias/removal#350735

Closed
roberth wants to merge 1 commit into
NixOS:masterfrom
hercules-ci:fix-netlify-cli-eval
Closed

netlify-cli: Fix eval for utillinux alias/removal#350735
roberth wants to merge 1 commit into
NixOS:masterfrom
hercules-ci:fix-netlify-cli-eval

Conversation

@roberth

@roberth roberth commented Oct 23, 2024

Copy link
Copy Markdown
Member

Fix an eval error.

This may be changing generated code, but the packaging will be
re-done in #336530 anyway.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This may be changing generated code, but the packaging will be
re-done in NixOS#336530 anyway.
@emilazy

emilazy commented Oct 23, 2024

Copy link
Copy Markdown
Member

Shouldn’t #349783 have already fixed this?

@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 23, 2024
@roberth

roberth commented Oct 23, 2024

Copy link
Copy Markdown
Member Author

It did!
I guess we'd do this treewide if we choose to go this route.
Also no update in nixos-unstable for 4 days then :/

@roberth roberth closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants