Skip to content

fix: Wrong message displaying when trying to set a home without arguments while having home limit reached. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thatsmusic99 merged 2 commits into from
Jan 10, 2026
Merged

fix: Wrong message displaying when trying to set a home without arguments while having home limit reached. #144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
862a72b
fix: Wrong message displaying when trying to set a home without argum…
Niestrat99 Jan 7, 2026
b550539
fix: Adjusted code based on assignee's comment.
Niestrat99 Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...kit/src/main/java/io/github/niestrat99/advancedteleport/commands/home/SetHomeCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ public boolean onCommand(
if (atPlayer.getHomes().isEmpty() && (limit > 0 || limit == -1)) {
setHome(player, "home");
return true;
} else if (atPlayer.getHomes().size() >= limit) { // If player has reached the homes limit already.

@Thatsmusic99 Thatsmusic99 Jan 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATPlayer#canSetMoreHomes should be used here instead

CustomMessages.sendMessage(sender, "Error.reachedHomeLimit");
return false;
}

// If the player is a floodgate player, send them a form, otherwise tell the player to
Expand Down
Loading