Rework the CQueue implementation - #38
Draft
NicolasT wants to merge 8 commits into
Draft
Conversation
Owner
Author
|
There's clearly some bug in the current implementation, since using it "for real" causes some tests to lock up. I might first rework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
CQueuefromdistributed-process, provide an implementation which is simpler and tailored to our needs.timeoutsupport (cfr. troupe: addafterin favor ofreceiveTimeout#36)non-blockingsupport (cfr. troupe: addafterin favor ofreceiveTimeout#36)This is meant to be a long-running PR to experiment on the implementation. The intent is for the implementation to be correct, not necessarily fast. Once it's correct, we can further work on its performance.
The tests for the implementation include some experiments with DejaFu to ensure the implementation produces consistent results and doesn't deadlock. Cfr. #17.