test: validate training resume after dataset deletion#683
Open
sdas-neuraco wants to merge 1 commit into
Open
Conversation
sdas-neuraco
force-pushed
the
test-integration-training-updates
branch
2 times, most recently
from
bd8e297 to
e282530
Compare
ypang-neuraco
requested changes
Jun 18, 2026
Comment on lines
+131
to
+134
| if dataset is not None: | ||
| if source_dataset is not None: | ||
| raise ValueError("Only one of source_dataset or dataset must be provided") | ||
| source_dataset = dataset |
Contributor
There was a problem hiding this comment.
Why do we need this alias?
Comment on lines
+214
to
+232
| def dataset_clone( | ||
| new_dataset_name: str, | ||
| *, | ||
| dataset: Dataset | None = None, | ||
| dataset_name: str | None = None, | ||
| dataset_id: str | None = None, | ||
| wait: bool = True, | ||
| ) -> Dataset: | ||
| """Clone a dataset and all of its recordings. | ||
|
|
||
| Alias for clone_dataset. | ||
| """ | ||
| return clone_dataset( | ||
| new_dataset_name, | ||
| dataset=dataset, | ||
| dataset_name=dataset_name, | ||
| dataset_id=dataset_id, | ||
| wait=wait, | ||
| ) |
Contributor
There was a problem hiding this comment.
Why do we need this alias?
Contributor
There was a problem hiding this comment.
Please rebase on main, I think your code is out of date
Comment on lines
+156
to
+160
| breakpoint() | ||
| with pytest.raises(ValueError) as exc_info: | ||
| nc.resume_training_run(job_id=job_id, additional_epochs=1) | ||
|
|
||
| breakpoint() |
Contributor
There was a problem hiding this comment.
Please clean up breakpoints
test: expand ML integration coverage fix: WIP
sdas-neuraco
force-pushed
the
test-integration-training-updates
branch
from
5eeb7b1 to
ed40637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary