Skip to content

build(packages): bump eslint-plugin-html from 8.1.4 to 8.2.0 - #252

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/eslint-plugin-html-8.2.0
Closed

build(packages): bump eslint-plugin-html from 8.1.4 to 8.2.0#252
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/eslint-plugin-html-8.2.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 1, 2026

Copy link
Copy Markdown
Contributor

Bumps eslint-plugin-html from 8.1.4 to 8.2.0.

Changelog

Sourced from eslint-plugin-html's changelog.

2026-08-28 v8.2.0

  • Add typescript types
  • Update dependencies
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) from 8.1.4 to 8.2.0.
- [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/main/CHANGELOG.md)
- [Commits](https://github.com/BenoitZugmeyer/eslint-plugin-html/commits)

---
updated-dependencies:
- dependency-name: eslint-plugin-html
  dependency-version: 8.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 1, 2026
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-enhanced Ready Ready Preview Sep 1, 2026 12:49pm UTC

@yukka-agent

yukka-agent Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR #252 代码审查启动中,正在分析依赖升级影响。
初步扫描已完成,准备生成详细的代码质量审查意见。

PR #252 审查报告: eslint-plugin-html 8.1.4 -> 8.2.0

PR 类型: dependabot 自动化依赖升级 | 范围: devDependencies | 风险等级:

Changelog v8.2.0 (2026-08-28): 仅 Add typescript types + Update dependencies, 无 Breaking Change, 兼容 eslint@9.39.5 (本仓库当前版本)。

Review Comments 建议

1. pnpm-lock.yaml:60-92 - package.json 未同步升级 specifier

Medium Priority

# pnpm-lock.yaml:91
  eslint-plugin-html:
    specifier: ^8.1.4  # 仍为旧版本声明
    version: 8.2.0
// package.json:106
"eslint-plugin-html": "^8.1.4" // 未变更

问题: pnpm-lock.yamlimportersspecifier 仍为 ^8.1.4,但 version 已指向 8.2.0。虽然 ^8.1.4 在语义上满足 8.2.0,但声明与锁定版本不一致,会造成 package.json 意图不清晰,后续 pnpm install 时语义模糊。

建议:

- "eslint-plugin-html": "^8.1.4",
+ "eslint-plugin-html": "^8.2.0",

由 Dependabot 正常应同时修改 package.json + pnpm-lock.yaml,本次仅改了 lockfile,需确认是否为 Dependabot 异常,建议执行 @dependabot rebase 或本地 pnpm up eslint-plugin-html@8.2.0 重新生成。

2. pnpm-lock.yaml 全文件 - 无关的 Lockfile 抖动 (+132/-132)

High Priority

# 大量与本次升级无关的变更,例如:
- version: 0.4.4
+ version: 0.4.4(debug@4.4.3(supports-color@5.5.0))(supports-color@5.5.0)
- eslint: 9.39.5
+ eslint: 9.39.5(supports-color@5.5.0)
- debug@4.4.3:
-   dependencies: { ms: 2.1.3 }
+ debug@4.4.3(supports-color@5.5.0):
+   dependencies: { ms: 2.1.3 }

问题: 本 PR 宣称只升级 eslint-plugin-html,实际 diff 包含 130+ 行 peer 依赖后缀 (...supports-color@5.5.0) 的格式化变更。这通常是不同 pnpm 版本 (本仓库 CI/文档约定 pnpm@9 --frozen-lockfile,见 AGENTS.md:3) 生成 lockfile 的差异导致,而非依赖本身变更。会污染 git blame,掩盖真实变更,增加 Review 成本。

建议:

  • 本地用仓库约定版本 pnpm@9 执行 pnpm install --frozen-lockfile 验证,再 pnpm up eslint-plugin-html@8.2.0 对比 diff 是否收敛到最小集。
  • 若确认是 Dependabot 使用了不同 pnpm 版本,可评论 @dependabot rebase 触发重建;或在仓库 package.json 增加 packageManager: "pnpm@9.x.x" 字段强制对齐。

3. pnpm-lock.yaml:1004-1009 - 完整性校验正确

Medium Priority

# pnpm-lock.yaml:1004
  eslint-plugin-html@8.2.0:
    resolution: {integrity: sha512-L6F37uij4uq3cZah46BawXeZlZYW9IfFeep7BwkuxBZA++BbihvEpoJPhq0NpCruPRzVkG/tpgvQYM53Re4pVA==}
    engines: {node: '>=16.0.0'}

检查: integritynpm view eslint-plugin-html@8.2.0 dist.integrity 一致 sha512-L6F37...engines >=16 满足仓库 Node >=12 / CI 18-24 环境,无供应链篡改风险。无 Security 问题。

4. eslint.config.js:3,31 - 兼容性与类型增量验证缺失

Medium Priority

// eslint.config.js:3,31
const html = require('eslint-plugin-html')
  plugins: { html, }

问题: v8.2.0 主要变更为 Add typescript types,本仓库 eslint.config.js:1 为 CommonJS (require),新增的 .d.ts 不影响运行时,但需确认 pnpm lint / pnpm docs:check 在新版本下仍通过。PR 未附带 CI 日志,无法确认。

建议: 合并前确保 CI 中 pnpm lint (ESLint 9 flat config) 通过,建议本地验证:

pnpm install --frozen-lockfile
pnpm lint

总结

维度 结论
功能影响 仅 dev 依赖,运行时无影响;html 插件用于 lint HTML 中的 <script>,升级无 Breaking Change
安全性 无 CVE,integrity 正确 Security 未发现安全问题
代码质量 Lockfile 噪声过大,影响可审计性;package.json 声明未同步
总体建议 Approve with comments - 可合并,但建议先处理 High Priority 的 lockfile 纯净度问题

合并策略: 低优先级依赖升级,建议 Squash 合并。若追求干净历史,执行 pnpm up eslint-plugin-html@8.2.0pnpm@9 重新生成仅包含 eslint-plugin-html@8.2.0 一处变更的 lockfile 后再合并。

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
api-enhanced 2992c2c Sep 01 2026, 12:50 PM

@dependabot @github

dependabot Bot commented on behalf of github Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Looks like eslint-plugin-html is up-to-date now, so this is no longer needed.

@dependabot dependabot Bot closed this Sep 4, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/eslint-plugin-html-8.2.0 branch September 4, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants