Test and Index fix#682
Conversation
Accessibility:
- Global :focus-visible keyboard focus ring (style.css; white variant in sidebar via menu.css)
- Nav toggles: hamburger and "Administration" submenu get aria-label/aria-expanded/aria-controls;
Administration is now a <button>; arrow marked aria-hidden
- Sidebar focus management: focus moves in on open, Esc closes and returns focus, closed
off-screen sidebar marked inert + aria-hidden (no longer tabbable)
- aria-live status regions + role=progressbar(aria-valuenow) for long-task/search feedback
(index, similarity, chat)
- Accessible combobox keyboard nav for the song autocomplete (similarity, map): Up/Down/Enter/Esc,
combobox/listbox/option roles, aria-activedescendant
Button system convergence:
- Make .btn a drop-in (0.75rem 1.5rem); add .btn-success and .btn-block utilities
- Migrate every primary-action button across 13 templates to .btn .btn-{primary,danger,success} .btn-block
- Remove duplicated per-page .danger-button/.active-button blocks, the per-ID color selector lists,
the !important green, and the brittle button[style*="#16A34A"] attribute selector
- Note: artist-similarity "Create Playlist" button is now green (success) for consistency with all
other "Create Playlist on Media Server" buttons
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a shared rate limiter using flask-limiter to protect authentication and user administration endpoints, and implements a versioned, ordered database migration framework. It also enhances frontend accessibility with improved keyboard navigation, ARIA attributes, and focus styles, while refactoring button styles into shared utility classes. Feedback on these changes highlights a potential startup crash if the rate limit configuration strings are empty, suggesting a check to ensure they are truthy before applying the decorator.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
2 participants
Test and Index fix
PR test builds:
ghcr.io/neptunehub/audiomuse-ai:pr-682ghcr.io/neptunehub/audiomuse-ai:pr-682-nvidiaghcr.io/neptunehub/audiomuse-ai:pr-682-noavx2