Add authentication to File Manager and Adminer views#630
Open
twinvega wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The File Manager and Adminer views in views.php had no
ensure_authenticated()call, unlike every other privileged view (System Controls, Services, Webterm,
Species Management, etc.).
This means anyone who sets
CADDY_PWDinbirdnet.confdirectly — a workarounddocumented in multiple community issues [1][2] — ends up with PHP auth
enforced but Caddy's
basicauthunchanged. The file manager at/scripts/filemanager/filemanager.phpremains accessible without credentials,exposing
birdnet.conf(including the plaintextCADDY_PWD) to unauthenticatedusers.
Fix: add
ensure_authenticated()before the File and Adminer includes,consistent with how Webterm is already handled.
Password Change Does Not Protect the File Manager
When a user sets a password by editing
/etc/birdnet/birdnet.confdirectly —a documented community workaround recommended in multiple GitHub issues [1][2]
—
update_caddyfile.shis never called.CADDY_PWDis set, PHP requires thepassword, but Caddy has no auth configured. The user confirms the login prompt
is working and believes the instance is secured. The file manager remains wide
open.
How it plays out
CADDY_PWD=hunter2in/etc/birdnet/birdnet.confupdate_caddyfile.shwas never run, or because it failed silently when called from the web interface (caddyis not in PHP's PATH, leavingHASHWORDempty and the generated Caddyfile malformed) — file manager remains accessiblebirdnet.conf:[1] mcguirepr89#889
[2] mcguirepr89#749