-
Notifications
You must be signed in to change notification settings - Fork 2
add some pagination functionality #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djds23
wants to merge
7
commits into
NYCPython:master
Choose a base branch
from
djds23:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3c6e533
some updates, working on pagignation
djds23 fb4a259
removed my bad ideas
djds23 ff195c6
change message number to 25 per page, attempt at pagination almost co…
djds23 6ebcf48
newest convos load first
djds23 5b14dc3
update the buttons for newer and older
djds23 9472dd9
Update app.js
djds23 fd165c0
rename functions and buttons for clarity
djds23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| from .core import api | ||
| from .models import Message | ||
|
|
||
| api.create_api(Message, url_prefix='/api/v1') | ||
| api.create_api(Message, results_per_page=25, url_prefix='/api/v1') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,16 +21,18 @@ | |
| <th>Timestamp</th> | ||
| <th>Nick</th> | ||
| <th>Message</th> | ||
| </thead> | ||
| </thead> | ||
| <tr ng-repeat="message in messages"> | ||
| <td>{{ message.created | date:'yyyy-MM-dd HH:mm:ss' }}</td> | ||
| <td>{{ message.nick }}</td> | ||
| <td>{{ message.body }}</td> | ||
| <td>{{ message.page }}</td> | ||
| </tr> | ||
| </table> | ||
| <button ng-click="last_page()">Last Page</button> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should probably be "Previous Page" or something similar rather than "Last Page". Otherwise, the meaning is ambiguous. |
||
| <button ng-click="next_page()">Next Page</button> | ||
| </div> | ||
| {% endraw %} | ||
|
|
||
| </script> | ||
| {% endblock %} | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's usually better to use
!==than!=.