Fix RMAT docs#3071
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates clang-format pragma matching for SPDX, refreshes SPDX header text, and fixes Doxygen comments across the rmat rectangular generator headers. One constructor check is also changed to match the updated documented output extent relationship. ChangesHeader and comment formatting cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Related issues: None specified. Related PRs: None specified. Suggested labels: documentation, non-breaking Suggested reviewers: None specified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cpp/include/raft/random/rmat_rectangular_generator.cuh`:
- Around line 64-65: The `@pre` contract in the rmat_rectangular_generator docs is
incorrect in both overloads: `out.extent(0)` should match `out_src.extent(0)`,
not `2 * out_src.extent(0)`. Update the documentation near the affected
overloads in `rmat_rectangular_generator.cuh` so the precondition reflects the
actual `n_edges x 2` mdspan shape and stays consistent with `out_src` and
`out_dst`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 55d24fc3-95bb-4f43-ac89-cfff3c61daa2
📒 Files selected for processing (3)
cpp/.clang-formatcpp/include/raft/random/detail/rmat_rectangular_generator.cuhcpp/include/raft/random/rmat_rectangular_generator.cuh
| BreakStringLiterals: true | ||
| ColumnLimit: 100 | ||
| CommentPragmas: '^ IWYU pragma:' | ||
| CommentPragmas: '(IWYU pragma:|SPDX-)' |
No description provided.