Skip to content

Remove the _is_cc_capable_gpu function #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuelh-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the _is_cc_capable_gpu function #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ func validateFlagsOrEnv(c *cli.Context) error {
if os.Getenv("NODE_NAME") == "" {
return fmt.Errorf("NODE_NAME env must be set for k8s-cc-manager")
}
if os.Getenv("CC_CAPABLE_DEVICE_IDS") == "" {
return fmt.Errorf("CC_CAPABLE_DEVICE_IDS env must be set for k8s-cc-manager")
}
return nil
}

Expand Down
36 changes: 0 additions & 36 deletions scripts/cc-manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
set -x

NODE_NAME=${NODE_NAME:?"Missing NODE_NAME env"}
CC_CAPABLE_DEVICE_IDS=${CC_CAPABLE_DEVICE_IDS:?"Missing CC_CAPABLE_DEVICE_IDS env"}
SANDBOX_VALIDATOR_DEPLOYED=""
SANDBOX_PLUGIN_DEPLOYED=""
VGPU_DEVICE_MANAGER_DEPLOYED=""
Expand All @@ -13,18 +12,6 @@ PAUSED_STR="paused-for-cc-mode-change"

# declare an empty array for cc capable GPUs
gpus=()
# device-ids of cc capable GPUs
device_ids=()

_populate_cc_capable_device_ids() {
# split CC_CAPABLE_DEVICE_IDS and populate device_ids
device_ids=($(echo $CC_CAPABLE_DEVICE_IDS | tr "," "\n"))
if [ ${#device_ids[@]} -eq 0 ]; then
echo "no cc capable device ids were passed"
return 1
fi
return 0
}

_reset_gpu_after_cc_mode() {
local gpu=$1
Expand Down Expand Up @@ -75,17 +62,6 @@ _get_all_cc_capable_gpus() {
done
}

_get_device_id() {
local $gpu=$1
local dev_path=/sys/bus/pci/devices/$gpu/device
if [ -e $dev_path ]; then
device_id=$(cat $dev_path)
return 0
fi
echo "device path $dev_path doesn't exist for $gpu"
return 1
}

_array_contains () {
local array="$1[@]"
local seeking=$2
Expand All @@ -99,15 +75,6 @@ _array_contains () {
return $in
}

_is_cc_capable_gpu() {
local $gpu=$1
device_id=$(_get_device_id $gpu)
if [ $? -ne 0 ]; then
return 1
fi
_array_contains device_ids "$device_id" && return 0 || return 1
}

_is_valid_mode() {
local mode=$1

Expand Down Expand Up @@ -512,9 +479,6 @@ if [ $# -ne 0 ]; then
usage
fi

# populate all cc capable gpus that we are interested in
_populate_cc_capable_device_ids || exit 1

# get all cc capable gpus
_get_all_cc_capable_gpus || exit 1

Expand Down
Loading