Skip to content

docs-build: switch to RTX Pro 6000, add changed-files filter #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 2 commits into from
Sep 10, 2026
+30 −6
Merged

docs-build: switch to RTX Pro 6000, add changed-files filter #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9325e2e
docs-build: switch to RTX Pro 6000
jameslamb Sep 10, 2026
ef192c8
empty commit to re-trigger CI
jameslamb Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,15 @@ jobs:
secrets:
GPUTESTER_CRATES_TOKEN: ${{ secrets.GPUTESTER_CRATES_TOKEN }}
uses: ./.github/workflows/publish-rust.yaml
docs-build-matrix:
permissions:
contents: read
uses: rapidsai/shared-workflows/.github/workflows/compute-matrix.yaml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
matrix_name: docs-build
docs-build:
needs: [docs-build-matrix]
if: github.ref_type == 'branch'
permissions:
actions: read
Expand All @@ -269,13 +277,16 @@ jobs:
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main
strategy:
fail-fast: false
matrix: ${{ fromJSON(needs.docs-build-matrix.outputs.matrix) }}
with:
arch: "amd64"
arch: "${{ matrix.arch }}"
branch: ${{ inputs.branch }}
build_type: ${{ inputs.build_type || 'branch' }}
container_image: "rapidsai/ci-conda:26.12-latest"
container_image: "rapidsai/ci-conda:26.12-cuda${{ matrix.CUDA_VER }}-${{ matrix.LINUX_VER }}-py${{ matrix.PY_VER }}"
date: ${{ inputs.date }}
node_type: "gpu-l4-latest-1"
node_type: "gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-1"
script: "ci/build_docs.sh"
sha: ${{ inputs.sha }}
wheel-build-libcuvs:
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- go-build-matrix
- go-build
- docs-build
- docs-build-matrix
- wheel-build-libcuvs
- wheel-build-cuvs
- wheel-tests-cuvs
Expand Down Expand Up @@ -737,7 +738,15 @@ jobs:
arch: "amd64"
container_image: "rapidsai/ci-conda:26.12-cuda${{ matrix.CUDA_VER }}-${{ matrix.LINUX_VER }}-py${{ matrix.PY_VER }}"
script: "ci/build_go.sh"
docs-build-matrix:
permissions:
contents: read
uses: rapidsai/shared-workflows/.github/workflows/compute-matrix.yaml@main
with:
build_type: pull-request
matrix_name: docs-build
docs-build:
needs: [docs-build-matrix]

@jameslamb jameslamb Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to not see any conda packages needed for the docs builds, but looks like that was an intentional change in #2067

permissions:
actions: read
contents: read
Expand All @@ -746,11 +755,15 @@ jobs:
pull-requests: read
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main
if: fromJSON(needs.changed-files.outputs.changed_file_groups).build_docs

@jameslamb jameslamb Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked like an omission, given that there's configuration for it:

cuvs/.github/workflows/pr.yaml

Lines 86 to 89 in 29e1101

uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@main
with:
files_yaml: |
build_docs:

This fixes that, so some types of PRs that don't affect the docs will not have a docs CI job.

strategy:
fail-fast: false
matrix: ${{ fromJSON(needs.docs-build-matrix.outputs.matrix) }}
with:
build_type: pull-request
node_type: "gpu-l4-latest-1"
arch: "amd64"
container_image: "rapidsai/ci-conda:26.12-latest"
node_type: "gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-1"
arch: "${{ matrix.arch }}"
container_image: "rapidsai/ci-conda:26.12-cuda${{ matrix.CUDA_VER }}-${{ matrix.LINUX_VER }}-py${{ matrix.PY_VER }}"
script: "ci/build_docs.sh"
wheel-build-libcuvs:
needs: [build-details, checks]
Expand Down
Loading